Fix #42 disappearing less show less #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The show less button dissapears after click show more for the second time. It looks like it was originally planned that there would be a seperate behaviour for explicit and implicit expand and collapse but I can't see that an implicit expand and collapse was ever implemented. As such all open and closes are explicit and the show less button shouldn't be removed unless we want to remove it (in which case it can be done manually in the appication logic)
If we have specified showLess and we have expanded the text we would expect a show less button.
Author
|
Note that I've not updated the version number in the package.json. Didn't want to cause conflicts with other pull requests so you might want to do that after merging if pushing to npm. |
Owner
|
Thanks! I will take a look within the next day. |
Author
|
Hi there, any chance this could be reviewed / merged? just looking to clean up some of the forks I have on github. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.