Ignore CORS

[jeffvli]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
feishin	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 8, 2023 at 10:24PM (UTC)

[github-actions]

Download the artifacts for this pull request:

• linux-binaries.zip
• macos-binaries.zip
• windows-binaries.zip

[jeffvli]

@lennartbrandin I've pushed some additional changes which I believe may fix the CORS issue. Can you try the updated build?

[lennartbrandin]

Using the linux-binaries.zip that the github-actions bot linked. (I assume them up to date because it updated a few hours ago)

I did not notice any different behavior than mentioned before.

[jeffvli]

Hmm.. I'm not sure why it's not working.

For reference, this is what's currently being applied:

1. webSecurity: false in the electron browser window web preferences.
2. Setting the fetch mode to cors

I did a bit of testing of my side albeit without using a self signed certificate but it seemed to ignore properly ignore CORS. I'll try some additional testing when I have the chance.

[lennartbrandin]

Screenshots from the debugging tool.

I've seen mentions of using an ignore certificate errors switch in addition to webPreference settings.
(Note that i've no/little experience using electron/ts)

[jeffvli]

Thanks for that info!
I've pushed another change that adds an additional "Ignore SSL" toggle in the server list.

Let me know how that goes after the publish build finishes.

[lennartbrandin]

I can confirm that this works, both for self signed certificates, as for domain mismatching certificates.
(Note that your auto updating feature may irritate when testing a unstable binary and it "updates" to the latest official release)

[jeffvli]

I'll add an additional toggle to disable automatic updates in a later pr.

[redthing1]

I still seem to be having CORS issues in my client though

[lennartbrandin]

Please try to provide more information about what you tried, what happend, what you expect would happen, and if possible logs/webconsole output.

[redthing1]

Is the web console on in production builds? How do I open it? If not I'll get back to you from running the dev version later

[jeffvli]

Ctrl + Shift + I or there's a menu option in the file menu to open the web devtools.

[redthing1]

Well, i'm on Feishin v0.5.2, and with the switch on^ (obviously I restarted)

[jeffvli]

I need more details like:

• What server are you using? (Navidrome or Jellyfin)
• Running the web or desktop version? (I'm assuming desktop here)
• Are all the API requests failing, and if not which ones are failing?
• Is your server being accessed behind a reverse proxy?
• If yes to the above, does switching to the private URL resolve the issue?

[redthing1]

• Jellyfin
• Desktop
• Other API requests (fetching album data, etc.) work fine, and our web frontend works fine. What's failing is specifically album covers
• Server is behind a reverse proxy. Accessing the private URL is not feasible in this case.

[redthing1]

Sadly, still appears to be broken on the latest version. I will investigate using the debug inspector at some point.