Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@Gauvino
Copy link

@Gauvino Gauvino commented Dec 27, 2023

Rework Dockerfiles

  • Re-organized dockerfile for better syntax
  • Changed Debian from 11 (Bullseye) to 12 (Bookworm)
  • Changed jellyfin-ffmpeg5 to 6
  • Upgrade version of Intel drivers
  • Remove wget (only using curl now)

Can be closed #38

Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally there was a new dependency added for rkmpp which is missing here too.

@Gauvino
Copy link
Author

Gauvino commented Feb 3, 2024

Ready to merge !

image

@Gauvino Gauvino requested a review from Shadowghost February 3, 2024 22:11
@DerP4si
Copy link

DerP4si commented Feb 23, 2024

Sorry to interrupt but can i help with testing? I need this merge to be done cause of Issue #10674 AMD VAAPI transcoding. What do i need to do? I know a bit about docker but i didnt understand wich files are needed within the dockerfile to build the new image correctly so i can test it - especially the vulkan api catched my eye ^^ Thx and thx for your work on jelly <3

@Gauvino
Copy link
Author

Gauvino commented Feb 23, 2024

Sorry to interrupt but can i help with testing? I need this merge to be done cause of Issue #10674 AMD VAAPI transcoding. What do i need to do? I know a bit about docker but i didnt understand wich files are needed within the dockerfile to build the new image correctly so i can test it - especially the vulkan api catched my eye ^^ Thx and thx for your work on jelly <3

This PR is ready to merge I don't have to make any other change live checked everything 5 times we now have to wait for the team review and merge and if feel free to ask me some questions !

Copy link

@gnattu gnattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerP4si
Copy link

DerP4si commented Feb 23, 2024

Sorry to interrupt but can i help with testing? I need this merge to be done cause of Issue #10674 AMD VAAPI transcoding. What do i need to do? I know a bit about docker but i didnt understand wich files are needed within the dockerfile to build the new image correctly so i can test it - especially the vulkan api catched my eye ^^ Thx and thx for your work on jelly <3

This PR is ready to merge I don't have to make any other change live checked everything 5 times we now have to wait for the team review and merge and if feel free to ask me some questions !

Gtk... So is it enough to dl your repo and "execute" the right dockerfile to have the newest jellyfin up n running?

@Gauvino
Copy link
Author

Gauvino commented Feb 23, 2024

Sorry to interrupt but can i help with testing? I need this merge to be done cause of Issue #10674 AMD VAAPI transcoding. What do i need to do? I know a bit about docker but i didnt understand wich files are needed within the dockerfile to build the new image correctly so i can test it - especially the vulkan api catched my eye ^^ Thx and thx for your work on jelly <3

This PR is ready to merge I don't have to make any other change live checked everything 5 times we now have to wait for the team review and merge and if feel free to ask me some questions !

Gtk... So is it enough to dl your repo and "execute" the right dockerfile to have the newest jellyfin up n running?

Of course no problem I've tested the image and I didn't have any problem, say to me if it fix your problem

@Gauvino Gauvino closed this Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants