-
-
Notifications
You must be signed in to change notification settings - Fork 6
Additional studios and networks #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Additional studios and networks #6
Conversation
cef8968
to
9a42027
Compare
@@ -0,0 +1,310 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contrast seems to be a bit low on those Amazon logos with gray background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for ARD and Das Erste. You could maybe do white on blue there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I noticed that too but wanted to keep the original color if possible.
Maybe we should switch the template to a white background so we don't have contrast problems with such logos?
I'd recommend running svgo over the SVG files to optimize them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The white background color definitely looks better. It might be a bit blinding for some, but at least the contrast is now up to standards, and the logos look the way they were intended.
@@ -1,20 +1,19 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rectangle is invisible now with the white background, should be inverted for the template (or converted into an outline).
Do note that SVGO is already run during build, currently: https://github.com/jellyfin/jellyfin-artwork/blob/master/.github/workflows/build_and_release.yml#L23-L24 The idea behind doing it this way was to keep easily editable files in the repository itself, since space isn't a concern (and the main concern for in-repo files is maintainability), while still ensuring that the final SVG files are as small as possible. |
Allright, should have looked at the pipeline, thanks for the heads-up. I still have all raw SVGs lying around so I'll redo everything and force push them. |
It's partly my fault, I didn't really document any of this before I left 😄 The general idea, in contrast to the Emby method, is that this repository is never queried directly by the users, so the files can be super messy and have stuff that make it easier to edit them (Inkscape tags and whatnot). Roughly, the process is this:
Both SVG and WebP are provided, since when discussing plans for this, we found out that Roku didn't support rendering SVGs, and other platforms might not (I believe Jellyfin itself had some issues with SVGs too, at least during my very limited testing of trying to upload SVG logos). WebP was chosen because it's more space-efficient, so it reduces storage for the server and network transmission. The server will convert it anyway if the client doesn't support it (TMDB already serves a bunch of stuff as WebP). |
PR to add some studios and networks.
Currently adds: