Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description formatting #968

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

theguymadmax
Copy link

Before:

B1

B2

After:

A1

A2

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.87%. Comparing base (8d1ae2e) to head (1acddcc).
Report is 99 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   21.87%   21.87%           
=======================================
  Files          63       63           
  Lines        8686     8686           
  Branches     1411     1411           
=======================================
  Hits         1900     1900           
  Misses       6767     6767           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks like Kodi is parsing the string literally, as opposed to the same way HTML is parsed. Based on the content here (
 are newline characters), this is likely new.

Would've been nice to know in which Kodi release this change happened.

The changelog is also affected, but that needs to be fixed in the script populating it, not here.

@oddstr13 oddstr13 merged commit 0ee29fc into jellyfin:master Jan 25, 2025
13 checks passed
@oddstr13 oddstr13 added chore cleanup Non-functional code cleanup/readability/formatting and removed chore labels Jan 25, 2025
@theguymadmax theguymadmax deleted the description-fix branch January 27, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional code cleanup/readability/formatting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants