Shallow clone fix #1698
Open
Shallow clone fix #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ened This test shows that deepening shallow clones works across all Git protocol versions. The trick to make this work is to pass depth=DEPTH_INFINITE Related to issue #1399
When fetching from a shallow clone with depth=DEPTH_INFINITE over HTTP, the client would fail with "unknown command" error. This happened because: 1. The HTTP client defers reading shallow updates until after the request 2. It unconditionally tries to read shallow updates when new_shallow is None 3. But the server may not send any shallow updates, causing _read_shallow_updates to try parsing regular protocol data (ACK/NAK) as shallow commands The fix checks if the first packet is actually a shallow/unshallow command before attempting to read shallow updates. If not, it assumes no shallow updates were sent and continues with normal protocol handling. Fixes issue when deepening a shallow clone to full depth over HTTP.
jelmer
force-pushed
the
shallow-clone-fix
branch
from
0dea09d to
704e4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.