Skip to content

fix: correct casing of NoTimeStamp parameter in saveToDailyNoteTool #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markgrovs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct casing of NoTimeStamp parameter in saveToDailyNoteTool #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/saveToDailyNote.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe("saveToDailyNoteTool", () => {
expect(saveToDailyNoteTool.parameters.shape.spaceId).toBeDefined();
expect(saveToDailyNoteTool.parameters.shape.mdText).toBeDefined();
expect(saveToDailyNoteTool.parameters.shape.origin.isOptional()).toBe(true);
expect(saveToDailyNoteTool.parameters.shape.noTimestamp.isOptional()).toBe(
expect(saveToDailyNoteTool.parameters.shape.NoTimeStamp.isOptional()).toBe(
true,
);
expect(typeof saveToDailyNoteTool.execute).toBe("function");
Expand Down
8 changes: 4 additions & 4 deletions src/tools/saveToDailyNote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ export const saveToDailyNoteTool = {
spaceId: string;
mdText: string;
origin?: "commandPalette";
noTimestamp?: boolean;
NoTimeStamp?: boolean; // <-- changed here
}) => {
try {
const requestBody = {
spaceId: args.spaceId,
mdText: args.mdText,
...(args.origin && { origin: args.origin }),
...(args.noTimestamp !== undefined && {
noTimestamp: args.noTimestamp,
...(args.NoTimeStamp !== undefined && {
NoTimeStamp: args.NoTimeStamp, // <-- changed here
}),
};

Expand Down Expand Up @@ -63,7 +63,7 @@ export const saveToDailyNoteTool = {
.describe(
"Optional origin label for the content (only 'commandPalette' is supported)",
),
noTimestamp: z
NoTimeStamp: z // <-- changed here
.boolean()
.optional()
.describe("If true, no time stamp will be added to the note"),
Expand Down