Add new command of 'add github labels to REPO' to bot (WIP) #72
Conversation
|
also need @bitwiseman's help to add support for updating labels, but waiting to hear back about the desired builder pattern for it. |
|
YAY! updating labels - hub4j/github-api#649 |
|
IDEA: change this to rebase repo, and make sure we have github topics of "jenkins" and "jenkins-plugin" setup |
|
@halkeye |
pom.xml
Outdated
| @@ -86,7 +86,7 @@ | |||
| <dependency> | |||
| <groupId>org.kohsuke</groupId> | |||
| <artifactId>github-api</artifactId> | |||
| <version>1.89</version> | |||
| <version>1.101</version> | |||
There was a problem hiding this comment.
| <version>1.101</version> | |
| <version>1.109</version> |
| /* | ||
| * when updateLabel is published | ||
| * repo.updateLabel( | ||
| * Strings.isNullOrEmpty(label.oldname) ? label.name : label.oldname, | ||
| * label.name, // newname | ||
| * label.color, | ||
| * label.description | ||
| * ) | ||
| */ |
There was a problem hiding this comment.
From hub4j/github-api#724 :
| /* | |
| * when updateLabel is published | |
| * repo.updateLabel( | |
| * Strings.isNullOrEmpty(label.oldname) ? label.name : label.oldname, | |
| * label.name, // newname | |
| * label.color, | |
| * label.description | |
| * ) | |
| */ | |
| ghLabels.get(Strings.isNullOrEmpty(label.oldname) ? label.name : label.oldname) | |
| .update() | |
| .name(label.name) // newname | |
| .color(label.color) | |
| .description(label.description) | |
| .done(); |
halkeye
force-pushed
the
add-github-labels
branch
from
ce5bc4c
to
de3c910
Compare
|
Is this still a WIP? |
|
Yea I rebased it but it needs a permanent location for the yaml and tests |
| private static final RepoLabels labelsYAML; | ||
| static { | ||
| try { | ||
| URL url = new URL("https://raw.githubusercontent.com/jenkinsci/.github/4f59a6219705df14067688df4f2a503e143cfa92/labels.yaml"); |
There was a problem hiding this comment.
master doesn't have the file so it would 404, but yea the plan would be master
|
Would be nice to get it over the line to avoid further merge conflicts |
|
https://plugins-self-service-3ir4b.ondigitalocean.app/ is way easier |
|
Looks nice though the UI does not seem to work for me (blank screen, maybe
long initial data loading).
Time to start a thread in the infra mailing list?
…On Tue, Jun 1, 2021 at 7:18 AM Gavin Mogan ***@***.***> wrote:
Closed #72 <#72>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RID4BFU6BTZMYTPHMVTTQRUT5ANCNFSM4J5U3YAQ>
.
|
WIP to support jenkinsci/.github#27