Implemented a small version for issue#688 #702

nagu165 · 2025-01-24T17:28:14Z

updated updatecli.d/jenkins-lts.yaml to update the jenkins recommended version

Testing done

Added 2 more targets in the updatecli.d/jenkins-lts.yaml to update the jenkins versions in recipes.yml
With the further input from the maintainers would like to work on it further.

Submitter checklist

[x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x ] Ensure that the pull request title represents the desired changelog entry
[x ] Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

nagu165 · 2025-01-24T17:29:56Z

Hello sir, Just wanted your input regarding these changes, would like to work on this further.
Please do tell me if i'm missing something.
Thank you.

gounthar · 2025-01-24T17:39:50Z

Changing it there is risky, as we might use the same keyword in different situations. I prefer to define a property in versions.property, keep it updated via updatecli, and then define a variable to use this property.

Thanks!

jonesbusy · 2025-01-24T17:43:43Z

What if we use a comment to match the version? "#recommanded version managed by updatecli"?

But I think a maven property with filtering on the resource looks more clean

…izer-tool into issue#688

nagu165 · 2025-01-26T09:57:23Z

Hello sir, As per your suggestion i'm trying to use maven filtering on the recipes.yml to dynamically update the version but filtering isn't working as expected, Please share any info on why this is so.
Thank you

jonesbusy · 2025-01-26T09:57:23Z

...dernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/config/RecipesConsts.java

@@ -19,4 +19,5 @@ private RecipesConsts() {
    public static final String OLD_BOM_VERSION_PATTERN =
            ""; // Old release line like 2.150.x, no need to filter by pattern
    public static final String INCREMENTAL_REPO_ID = "incrementals";
+    public static final String JENKINS_CORE_VERSION = "${jenkins.core.minimum.version}";


Why not Settings.getJenkinsMinimumVersion() instead of filtering java source?

Sorry sir, I missed it.
updating now.
Thank you.

jonesbusy · 2025-01-26T09:58:10Z

plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml

@@ -148,7 +148,7 @@ recipeList:
      artifactId: plugin
      newVersion: 5.X
  - io.jenkins.tools.pluginmodernizer.core.recipes.UpgradeJenkinsVersion:
-      minimumVersion: 2.479.1
+      minimumVersion: "${jenkins.core.minimum.version}"


This is not the minimum version. This value should not be changed since it's the first LTS supporting Java 17 and required for parent 5.x upgrade.

Only value https://github.com/jenkins-infra/plugin-modernizer-tool/pull/685/files must be filtered/changed

In the example that sir gave i.e #685 this was also modified so i was testing with this.
Now i understand the issue.
Thanks.

Only 2.452.4 was incremented to 2.462.3. The rest of value must not be changed

Yes sir, I misunderstood previously
Now i understand my mistake
Thank you.

jonesbusy · 2025-01-26T09:59:40Z

plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml

@@ -442,7 +442,7 @@ recipeList:
      artifactId: plugin
      newVersion: 4.51 # See https://www.jenkins.io/blog/2022/12/14/require-java-11/
  - io.jenkins.tools.pluginmodernizer.core.recipes.UpgradeJenkinsVersion:
-      minimumVersion: 2.346.3


This is NOT the minimum version. It's the last LTS supporting Java 8. This value will never changes

jonesbusy · 2025-01-26T10:07:06Z

plugin-modernizer-core/pom.xml

        <directory>src/main/resources/META-INF/rewrite</directory>
        <includes>
          <include>recipes.yml</include>
        </includes>
      </resource>
+      <resource>


To be removed

jonesbusy · 2025-01-26T18:02:06Z

Hello sir, As per your suggestion i'm trying to use maven filtering on the recipes.yml to dynamically update the version but filtering isn't working as expected, Please share any info on why this is so.
Thank you

I do not know if you don't share details

jonesbusy · 2025-01-26T18:03:19Z

plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml

@@ -416,7 +416,7 @@ recipeList:
  - io.jenkins.tools.pluginmodernizer.UpgradeParentVersion
  - io.jenkins.tools.pluginmodernizer.AddPluginsBom
  - io.jenkins.tools.pluginmodernizer.core.recipes.UpgradeJenkinsVersion:
-      minimumVersion: 2.462.3
+      minimumVersion: "${jenkins.core.minimum.version}"


I don't see it in the pom

…izer-tool into issue#688

nagu165 · 2025-01-27T03:26:32Z

Hello sir, in versions.properties - openrewrite.maven.plugin.version = ${openrewrite.maven.plugin.version} is causing circular refernce error so i replaced it with a constant for now, How to modify it properly without any breaking changes.
Thank you.

nagu165 · 2025-01-28T10:16:03Z

Is this change okay?

jonesbusy · 2025-01-29T10:41:26Z

Tests are failing

jonesbusy · 2025-01-29T10:43:04Z

plugin-modernizer-core/src/main/resources/versions.properties

@@ -1,4 +1,4 @@
-openrewrite.maven.plugin.version = ${openrewrite.maven.plugin.version}
+openrewrite.maven.plugin.version = 5.10.0


This is not correct. We need to continue filtering from the pom

jonesbusy · 2025-01-29T12:17:24Z

plugin-modernizer-core/pom.xml

@@ -227,6 +227,26 @@
    </resources>
    <plugins>

+      <plugin>


What is the reason to override the properties-maven-plugin rather than adding a new ?

But i did add a unique execution id so, won't it run concurrently instead of overriding?

nagu165 · 2025-01-30T09:44:51Z

Hello sir, The tests are failing on linux
Maybe because of the change intoduced in the pom, do i need to modify the test cases in CommandLineITCase.java or is there another approach as i'm stuck troubleshooting this and couldn't find a better solution yet.
Thank you.

…izer-tool into issue#688

nagu165 · 2025-01-31T15:22:28Z

Hello sir, Some errors seems to be introduced recently, tests are failing in "UpgradeJenkinsVersionTest", could you please take a look at that.

…izer-tool into issue#688

…zer-tool into issue#688

jonesbusy · 2025-02-06T05:22:27Z

Superseded by #776

Implemented a small version for issue#688

26ff49d

nagu165 requested a review from jonesbusy as a code owner January 24, 2025 17:28

nagu165 marked this pull request as draft January 24, 2025 17:30

Merge branch 'main' of https://github.com/jenkins-infra/plugin-modern…

415f0ba

…izer-tool into issue#688

jonesbusy mentioned this pull request Jan 25, 2025

Automate the jenkins recommended version in the UpgradeToRecommendCoreVersion and IsUsingRecommendCoreVersion recipes #688

Closed

nagu165 added 4 commits January 25, 2025 22:26

Little test to check the working

7e66f2c

Merge branch 'main' of https://github.com/jenkins-infra/plugin-modern…

33b1125

…izer-tool into issue#688

Merge branch 'main' of https://github.com/jenkins-infra/plugin-modern…

84a6647

…izer-tool into issue#688

Tried to update maven filtering

b693c06

jonesbusy reviewed Jan 26, 2025

View reviewed changes

Modifications as per suggestions

092629f

jonesbusy reviewed Jan 26, 2025

View reviewed changes

nagu165 added 2 commits January 27, 2025 08:52

Resolved filtering error

302854d

Merge branch 'main' of https://github.com/jenkins-infra/plugin-modern…

502acb8

…izer-tool into issue#688

Spotless

920f880

jonesbusy reviewed Jan 29, 2025

View reviewed changes

nagu165 added 2 commits January 29, 2025 18:40

Updates required

7d03c38

Some suggestions implemented

12076a2

nagu165 added 2 commits January 30, 2025 13:37

Minor issue resolved

80c46f7

Fixed minor errors

767db6e

Merge branch 'main' of https://github.com/jenkins-infra/plugin-modern…

c1de176

…izer-tool into issue#688

nagu165 and others added 7 commits January 31, 2025 20:53

Merge branch 'main' into issue#688

bc75bb2

Merge branch 'main' of https://github.com/jenkins-infra/plugin-modern…

b4c57c6

…izer-tool into issue#688

Merge branch 'main' into issue#688

4acc510

Some more updates

ac32f28

Merge branch 'issue#688' of https://github.com/nagu165/plugin-moderni…

e03295f

…zer-tool into issue#688

Merge branch 'main' into issue#688

646f882

Merge branch 'main' into issue#688

907d89f

jonesbusy mentioned this pull request Feb 6, 2025

Recipe filtering #776

Merged

6 tasks

jonesbusy closed this Feb 6, 2025

nagu165 deleted the issue#688 branch February 6, 2025 05:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented a small version for issue#688 #702

Implemented a small version for issue#688 #702

nagu165 commented Jan 24, 2025

nagu165 commented Jan 24, 2025

gounthar commented Jan 24, 2025

jonesbusy commented Jan 24, 2025

nagu165 commented Jan 26, 2025

jonesbusy Jan 26, 2025

nagu165 Jan 26, 2025

jonesbusy Jan 26, 2025

jonesbusy Jan 26, 2025

nagu165 Jan 26, 2025

jonesbusy Jan 26, 2025

nagu165 Jan 26, 2025

jonesbusy Jan 26, 2025

jonesbusy Jan 26, 2025

jonesbusy commented Jan 26, 2025

jonesbusy Jan 26, 2025

nagu165 commented Jan 27, 2025

nagu165 commented Jan 28, 2025

jonesbusy commented Jan 29, 2025

jonesbusy Jan 29, 2025

jonesbusy Jan 29, 2025

nagu165 Jan 30, 2025

nagu165 commented Jan 30, 2025

nagu165 commented Jan 31, 2025

jonesbusy commented Feb 6, 2025

		@@ -1,4 +1,4 @@
		openrewrite.maven.plugin.version = ${openrewrite.maven.plugin.version}
		openrewrite.maven.plugin.version = 5.10.0

Implemented a small version for issue#688 #702

Implemented a small version for issue#688 #702

Conversation

nagu165 commented Jan 24, 2025

Testing done

Submitter checklist

nagu165 commented Jan 24, 2025

gounthar commented Jan 24, 2025

jonesbusy commented Jan 24, 2025

nagu165 commented Jan 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonesbusy commented Jan 26, 2025

Choose a reason for hiding this comment

nagu165 commented Jan 27, 2025

nagu165 commented Jan 28, 2025

jonesbusy commented Jan 29, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nagu165 commented Jan 30, 2025

nagu165 commented Jan 31, 2025

jonesbusy commented Feb 6, 2025