fix: Don't use tagless images unless they're pod template names #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See jenkins-x/jx#4615. Regardless of what we do about that issue in the end, we shouldn't be using `gcr.io/jenkinsxio/builder-go` as the image in the first place. `go` (i.e., referring to the pod template name) will always pick up the latest in the version stream, which is what we'd want anyway (and what we do everywhere else here). Signed-off-by: Andrew Bayer <[email protected]>
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkins-x/jx#4615. Regardless of what we
do about that issue in the end, we shouldn't be using
gcr.io/jenkinsxio/builder-goas the image in the first place.go(i.e., referring to the pod template name) will always pick up the
latest in the version stream, which is what we'd want anyway (and what
we do everywhere else here).
Signed-off-by: Andrew Bayer [email protected]