Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

feat: create SA in EKS based on aws.helmSa #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gazal-k
Copy link

@gazal-k gazal-k commented Mar 31, 2020

  • if jxRequirements.cluster.aws.helmSa is true: create SA with annotations to bind to the IAM Role with convention: arn:aws:iam::<accountId>:role/<clustername>-<namespace>-<saName>
  • otherwise: don't create SA

fix jenkins-x-labs/issues#17

@jstrachan
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gazal-k
Copy link
Author

gazal-k commented Mar 31, 2020

This PR depends on:

@gazal-k
Copy link
Author

gazal-k commented Apr 1, 2020

/assign @jstrachan

@gazal-k
Copy link
Author

gazal-k commented Apr 1, 2020

/assign @rawlingsj

@gazal-k
Copy link
Author

gazal-k commented Apr 1, 2020

/assign @rawlingsj

that was me testing the chatops here. Is this running jxl or jx ?

@ghost
Copy link

ghost commented Apr 1, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pmuir
You can assign the PR to them by writing /assign @pmuir in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost
Copy link

ghost commented Apr 1, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gazal-k gazal-k changed the title feat: create SA in EKS based on aws.useIRSAAnnotations feat: create SA in EKS based on aws.helmSa Apr 1, 2020
@gazal-k gazal-k force-pushed the awsconfig branch 2 times, most recently from bf54bfc to 4da165b Compare April 7, 2020 10:18
- if `jxRequirements.cluster.aws.helmSa` is true: create SA with annotations to bind to the IAM Role with convention: `arn:aws:iam::<accountId>:role/<clustername>-<namespace>-<saName>`
- otherwise: don't create SA

fix jenkins-x-labs/issues#17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another mechanism for IAM Roles for Service Account creation in EKS
2 participants