Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for stringParams in vaultCredentialsId #138

Closed
ernstvonoelsen opened this issue Oct 13, 2023 · 2 comments · Fixed by #166
Closed

Allow for stringParams in vaultCredentialsId #138

ernstvonoelsen opened this issue Oct 13, 2023 · 2 comments · Fixed by #166

Comments

@ernstvonoelsen
Copy link

ernstvonoelsen commented Oct 13, 2023

What feature do you want to see added?

For the sake of re-usability, I'd like to be able configure freeStyleJobs that invoke an ansiblePlaybook via

job('My_Job') {
    steps {
            ansiblePlaybook('path/to/my/playbook.yml') {
                inventoryPath('${inventory_repository}/inventory.yml')
                vaultCredentialsId('${vault_credentials_id}')
            }
    }
    parameters {
        stringParam('inventory_repository')
        stringParam('vault_credentials_id')
    }
}

where both inventory_repository and vault_credentials_id are provided at build-time only.

While this works fine for inventoryPath, it does not for vaultCredentialsId (after processing the provided JobDSL file, the vault credentials setting in the Drop-Down menu is set to - current -.

Upstream changes

No response

@jonesbusy
Copy link
Contributor

Hi,

This will be fixed by #166

I would like to perform a release before (in case I need to rollback). But normally it should not have any side effect.

Also configured with automated tests.

Expected a release if some days.

Regards,

jonesbusy added a commit to jonesbusy/ansible-plugin that referenced this issue Dec 21, 2023
jonesbusy added a commit to jonesbusy/ansible-plugin that referenced this issue Dec 21, 2023
jonesbusy added a commit that referenced this issue Dec 21, 2023
@jonesbusy
Copy link
Contributor

@ernstvonoelsen Implemented on 301.v29a_7f9b_0d820

Can you confirm it works for you ?

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants