Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #138 by expanding credentials ID #166

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix #138 by expanding credentials ID #166

merged 1 commit into from
Dec 21, 2023

Conversation

jonesbusy
Copy link
Contributor

Fix #138 by expanding credentials ID

Testing done

Interactive tests and created test

mvn -Dtest=JobDslIntegrationTest#shouldCreateJobWithVarExpander clean test

Submitter checklist
Preview Give feedback

@jonesbusy jonesbusy self-assigned this Dec 21, 2023
@jonesbusy jonesbusy requested a review from a team as a code owner December 21, 2023 08:43
@jonesbusy jonesbusy mentioned this pull request Dec 21, 2023
Closed
@jonesbusy jonesbusy force-pushed the feature/expand-credentials-id branch from ef6a567 to bf3a93a Compare December 21, 2023 08:59
@jonesbusy jonesbusy force-pushed the feature/expand-credentials-id branch from bf3a93a to 8247eaf Compare December 21, 2023 09:15
@jonesbusy jonesbusy merged commit 29a7f9b into jenkinsci:main Dec 21, 2023
16 checks passed
@jonesbusy jonesbusy deleted the feature/expand-credentials-id branch December 21, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonesbusy jonesbusy

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for stringParams in vaultCredentialsId
1 participant
@jonesbusy