Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for spotbugs 4.8.3 #176

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Suppress warnings for spotbugs 4.8.3 #176

merged 1 commit into from
Jan 16, 2024

Conversation

MarkEWaite
Copy link
Contributor

Suppress warnings for spotbugs 4.8.3

Plugin pom 4.77 needs this change to resolve new spotbugs warnings that will be reported by spotbugs 4.8.3 and later.

Can skip the changelog, since this is not visible to users.

Testing done

Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible.

Confirmed that spotbugs is silent with plugin pom 4.77 after this change.

Submitter checklist

Preview Give feedback

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77
plugin pom 4.77 needs this change to resolve new spotbugs warnings
that will be reported by spotbugs 4.8.3 and later.

Can skip the changelog, since this is not visible to users.

Confirmed that the spotbugs warnings are visible when using the
4.77-SNAPSHOT plugin pom before this change. With this change, the
spotbugs warnings are no longer visible.

Confirmed that spotbugs is silent with plugin pom 4.77 after this
change.
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 16, 2024 01:33
@jonesbusy
Copy link
Contributor

Thanks!

@jonesbusy jonesbusy merged commit 1cdbe50 into jenkinsci:main Jan 16, 2024
16 checks passed
@MarkEWaite MarkEWaite deleted the suppress-more-spotbugs-warnings branch January 16, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants