Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSR-305 annotations with spotbugs annotations #213

Merged
merged 1 commit into from
May 8, 2024
Merged

Replace JSR-305 annotations with spotbugs annotations #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/jenkinsci/plugins/ansible/AnsibleAdHocCommandBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import com.cloudbees.plugins.credentials.CredentialsProvider;
import com.cloudbees.plugins.credentials.common.StandardCredentials;
import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials;
import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.AbortException;
import hudson.EnvVars;
Expand All @@ -33,7 +34,6 @@
import java.io.File;
import java.io.IOException;
import java.util.List;
import javax.annotation.Nonnull;
import jenkins.tasks.SimpleBuildStep;
import org.apache.commons.lang.StringUtils;
import org.kohsuke.stapler.DataBoundConstructor;
Expand Down Expand Up @@ -227,7 +227,7 @@ public void setExtraVars(List<ExtraVar> extraVars) {

@Override
public void perform(
@Nonnull Run<?, ?> run, @Nonnull FilePath ws, @Nonnull Launcher launcher, @Nonnull TaskListener listener)
@NonNull Run<?, ?> run, @NonNull FilePath ws, @NonNull Launcher launcher, @NonNull TaskListener listener)
throws InterruptedException, IOException {
try {
CLIRunner runner = new CLIRunner(run, ws, launcher, listener);
Expand Down
14 changes: 7 additions & 7 deletions src/main/java/org/jenkinsci/plugins/ansible/AnsiblePlaybookBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import com.cloudbees.plugins.credentials.CredentialsProvider;
import com.cloudbees.plugins.credentials.common.StandardCredentials;
import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials;
import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.AbortException;
import hudson.EnvVars;
Expand All @@ -35,7 +36,6 @@
import java.io.File;
import java.io.IOException;
import java.util.List;
import javax.annotation.Nonnull;
import jenkins.tasks.SimpleBuildStep;
import org.apache.commons.lang.StringUtils;
import org.kohsuke.stapler.DataBoundConstructor;
Expand Down Expand Up @@ -266,7 +266,7 @@ public void setExtraVars(List<ExtraVar> extraVars) {

@Override
public void perform(
@Nonnull Run<?, ?> run, @Nonnull FilePath ws, @Nonnull Launcher launcher, @Nonnull TaskListener listener)
@NonNull Run<?, ?> run, @NonNull FilePath ws, @NonNull Launcher launcher, @NonNull TaskListener listener)
throws InterruptedException, IOException {
Computer computer = ws.toComputer();
Node node;
Expand All @@ -277,11 +277,11 @@ public void perform(
}

public void perform(
@Nonnull Run<?, ?> run,
@Nonnull Node node,
@Nonnull FilePath ws,
@Nonnull Launcher launcher,
@Nonnull TaskListener listener,
@NonNull Run<?, ?> run,
@NonNull Node node,
@NonNull FilePath ws,
@NonNull Launcher launcher,
@NonNull TaskListener listener,
EnvVars envVars)
throws InterruptedException, IOException {
try {
Expand Down
14 changes: 7 additions & 7 deletions src/main/java/org/jenkinsci/plugins/ansible/AnsibleVaultBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.cloudbees.plugins.credentials.CredentialsProvider;
import com.cloudbees.plugins.credentials.common.StandardCredentials;
import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.AbortException;
import hudson.EnvVars;
Expand All @@ -31,7 +32,6 @@
import hudson.util.FormValidation;
import java.io.File;
import java.io.IOException;
import javax.annotation.Nonnull;
import jenkins.tasks.SimpleBuildStep;
import org.apache.commons.lang.StringUtils;
import org.kohsuke.stapler.DataBoundConstructor;
Expand Down Expand Up @@ -114,7 +114,7 @@ public void setOutput(String output) {

@Override
public void perform(
@Nonnull Run<?, ?> run, @Nonnull FilePath ws, @Nonnull Launcher launcher, @Nonnull TaskListener listener)
@NonNull Run<?, ?> run, @NonNull FilePath ws, @NonNull Launcher launcher, @NonNull TaskListener listener)
throws InterruptedException, IOException {
Computer computer = ws.toComputer();
Node node;
Expand All @@ -125,11 +125,11 @@ public void perform(
}

public void perform(
@Nonnull Run<?, ?> run,
@Nonnull Node node,
@Nonnull FilePath ws,
@Nonnull Launcher launcher,
@Nonnull TaskListener listener,
@NonNull Run<?, ?> run,
@NonNull Node node,
@NonNull FilePath ws,
@NonNull Launcher launcher,
@NonNull TaskListener listener,
EnvVars envVars)
throws InterruptedException, IOException {
try {
Expand Down