Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove defaults jobsdsl forks value #34

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

remove defaults jobsdsl forks value #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5cd9e4
removing jobdsl default
nbutkowski Apr 15, 2020
bffd86b
Update README.md
nbutkowski Apr 15, 2020
622ff22
Update README.md
nbutkowski Apr 15, 2020
ad25b54
master: Updating default test
nbutkowski-chub Apr 15, 2020
57a36ad
Update README.md
nbutkowski Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ It is possible to access build and environment variables in ansible playbooks. T

## Job DSL support

Note that some of these parameters are passed in to ansible as CLI arguments and take presedent over other ansible configurations.

```groovy
steps {
ansiblePlaybook(String playbook) {
Expand All @@ -35,7 +37,7 @@ steps {
becomeUser(String user = 'root')
sudo(boolean sudo = true)
sudoUser(String user = 'root')
forks(int forks = 5)
forks(int forks = 0)
unbufferedOutput(boolean unbufferedOutput = true)
colorizedOutput(boolean colorizedOutput = false)
hostKeyChecking(boolean hostKeyChecking = false)
Expand All @@ -55,7 +57,7 @@ steps {
becomeUser(String user = 'root')
sudo(boolean sudo = true)
sudoUser(String user = 'root')
forks(int forks = 5)
forks(int forks = 0)
unbufferedOutput(boolean unbufferedOutput = true)
colorizedOutput(boolean colorizedOutput = false)
hostKeyChecking(boolean hostKeyChecking = false)
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jenkinsci/plugins/ansible/jobdsl/context/AnsibleContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class AnsibleContext implements Context {
private String becomeUser = "root";
private boolean sudo = false;
private String sudoUser = "root";
private int forks = 5;
private int forks;
private boolean unbufferedOutput = true;
private boolean colorizedOutput = false;
private boolean disableHostKeyChecking = false;
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/jenkinsci/plugins/ansible/jobdsl/JobDslIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public void shouldCreateJobAdhocDsl() throws Exception {
assertThat("hostPattern", step.hostPattern, is("pattern"));
assertThat("become", step.become, is(false));
assertThat("becomeUser", step.becomeUser, is("root"));
assertThat("forks", step.forks, is(5));
assertThat("forks", step.forks, is(0));
assertThat("unbufferedOutput", step.unbufferedOutput, is(true));
assertThat("colorizedOutput", step.colorizedOutput, is(false));
assertThat("disableHostKeyChecking", step.disableHostKeyChecking, is(false));
Expand Down