Putting all embedded items in one directory per build - #15
Open
BenchmarkingBanana wants to merge 1 commit into
Open
Putting all embedded items in one directory per build#15BenchmarkingBanana wants to merge 1 commit into
BenchmarkingBanana wants to merge 1 commit into
Conversation
when using multiple tests with the same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
this is the second of three pull requests for little bugs I ran into using this plugin. I am creating one pull request for each fix, so you can take a look at one thing at a time and choose whether to merge it or not. Either way, I hope, you merge all three of them.
This is concerning a problem that shows up on some systems using two cucumber tests with the same name. The plugin uses then an underscore to differ between the tests. The problem is, that somehow it does not place the second image in the second directory. As I said, I only saw the issue on one system we use. When I tried to reproduce it on another one, everything worked. But to just make it easier, I now let the plugin put all the embedded items for one build into one folder. Format is: /builds/number/cucumber/embed/
Because all the files are named randomly and the method creating the names checks for duplicates, this is not a problem and just makes it easier to work with the plugin.