Skip to content

Html escaping for URIs and paths in the filesystem #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenchmarkingBanana wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Html escaping for URIs and paths in the filesystem #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/jenkinsci/plugins/cucumber/jsontestsupport/FeatureResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.kohsuke.stapler.StaplerResponse;
import org.kohsuke.stapler.export.Exported;
import org.kohsuke.stapler.export.ExportedBean;
import org.springframework.web.util.HtmlUtils;

/**
* Represents a single Feature in Cucumber.
Expand Down Expand Up @@ -163,10 +164,10 @@ void addScenarioResult(ScenarioResult scenarioResult) {
@Override
public synchronized String getSafeName() {
if (safeName != null) {
return safeName;
return HtmlUtils.htmlEscape(safeName);
}
safeName = uniquifyName(parent.getChildren(), safe(feature.getId()));
return safeName;
return HtmlUtils.htmlEscape(safeName);
}

@Override
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/jenkinsci/plugins/cucumber/jsontestsupport/ScenarioResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.kohsuke.stapler.export.ExportedBean;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.springframework.web.util.HtmlUtils;

import java.io.File;
import java.io.FileInputStream;
Expand Down Expand Up @@ -121,7 +122,7 @@ public int getFailCount() {
@Override
public synchronized String getSafeName() {
if (safeName != null) {
return safeName;
return HtmlUtils.htmlEscape(safeName);
}
String name = safe(scenario.getId());
String parentName = parent.getSafeName() + ';';
Expand All @@ -130,7 +131,7 @@ public synchronized String getSafeName() {
name = name.replace(parentName, "");
}
safeName = uniquifyName(parent.getChildren(), name);
return safeName;
return HtmlUtils.htmlEscape(safeName);
}

@Override
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/jenkinsci/plugins/cucumber/jsontestsupport/TagResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@

import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.StaplerResponse;
import org.springframework.web.util.HtmlUtils;

/**
* A TagResult is a pseudo result to link scenarios with the same tag.
Expand Down Expand Up @@ -149,10 +150,10 @@ void addScenarioResult(ScenarioResult scenarioResult) {
public synchronized String getSafeName() {
// no need to make unique as tags are shared!
if (safeName != null) {
return safeName;
return HtmlUtils.htmlEscape(safeName);
}
safeName = safe(getName());
return safeName;
return HtmlUtils.htmlEscape(safeName);
}


Expand Down