Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code formatting for changed files #256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sarah-witt
Copy link
Collaborator

What does this PR do?

  • Adds a spotless code formatting step that runs in the test phase
  • Only files changed against master are verified/formatted

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt sarah-witt marked this pull request as ready for review November 18, 2021 20:48
@@ -167,6 +167,31 @@
</archive>
</configuration>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Maybe we can add some instructions to the README file? Do we need to add some rules?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do that. I was thinking for now it can be just for the files changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note in CONTRIBUTING.md!

@github-actions github-actions bot added the documentation Documentation related changes label Dec 22, 2021
ofek
ofek previously approved these changes Dec 27, 2021
@ofek
Copy link
Collaborator

ofek commented Dec 27, 2021

Needs rebasing

@sarah-witt
Copy link
Collaborator Author

Thanks, updated!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related changes stale Stale - Bot reminder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants