Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Datadog clients #408

Merged

Conversation

nikita-tkachenko-datadog
Copy link
Collaborator

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Apr 8, 2024

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Refactors the "client" classes that the plugin uses to interact with Datadog Agent or Datadog backend: the code is simplified, some redundant state is being removed, client singleton instance now lives inside a dedicated holder class (that used to be client factory).

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review April 30, 2024 08:03
@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/no-changelog Changes don't appear in changelog label Apr 30, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/datadog-clients-refactoring branch from e3759eb to e87b5c6 Compare July 3, 2024 10:01
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/datadog-clients-refactoring branch from e87b5c6 to f048a44 Compare August 16, 2024 08:40
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 0bac4ae into master Sep 11, 2024
18 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/datadog-clients-refactoring branch September 11, 2024 18:04
@nikita-tkachenko-datadog nikita-tkachenko-datadog added changelog/Added Added features results into a minor version bump and removed changelog/no-changelog Changes don't appear in changelog labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants