-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusive naming changes #149
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -57,7 +57,7 @@ Release date: 2019-10-22 | |||||
> **NOTE**: To revert to previous release behavior, pass the system property | ||||||
> `org.jenkinsci.plugins.durabletask.BourneShellScript.FORCE_SHELL_WRAPPER=true` to the Java command line used to start Jenkins. | ||||||
|
||||||
- Update ssh-slaves ([PR \#100](https://github.com/jenkinsci/durable-task-plugin/pull/100)) | ||||||
- Update ssh-agents ([PR \#100](https://github.com/jenkinsci/durable-task-plugin/pull/100)) | ||||||
- Do not fail tests when run on a machine without Docker installed. | ||||||
([PR \#101](https://github.com/jenkinsci/durable-task-plugin/pull/101)) | ||||||
- Improve watcher logging | ||||||
|
@@ -89,7 +89,7 @@ Release date: 2019-07-05 | |||||
be used to enable zombie-reaping in docker containers (--init) or kubernetes pods (shared | ||||||
process namespaces). | ||||||
- Bugfix: Use `sh` to run shell scripts rather than attempting to | ||||||
use the absolute path to the default shell from the master on | ||||||
use the absolute path to the default shell from the Controller on | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lower case rather than upper case inside the sentence
Suggested change
|
||||||
agents. ([PR \#95](https://github.com/jenkinsci/durable-task-plugin/pull/95)) | ||||||
- Bugfix: Make PowerShell exit codes propagate correctly. Fixes a | ||||||
regression from version 1.23 | ||||||
|
@@ -129,7 +129,7 @@ Release date: 2018-09-25 | |||||
processes from 15 seconds to 5 minutes | ||||||
([JENKINS-48300](https://issues.jenkins-ci.org/browse/JENKINS-48300)) | ||||||
- Developer: Define API for pushing durable task logs from build | ||||||
agents directly instead of having the Jenkins master pull logs from | ||||||
agents directly instead of having the Jenkins controller pull logs from | ||||||
build agents | ||||||
([JENKINS-52165](https://issues.jenkins-ci.org/browse/JENKINS-52165)) | ||||||
|
||||||
|
@@ -338,7 +338,7 @@ Release date: 2015-12-03 | |||||
Release date: 2015-04-08 | ||||||
|
||||||
- Do not kill a one-shot agent merely because a flyweight task | ||||||
happened to run on it (rather than on master as usual). Works around | ||||||
happened to run on it (rather than on the Controller as usual). Works around | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lower case
Suggested change
|
||||||
a bug in the Multibranch API plugin. | ||||||
|
||||||
### Version 1.5 | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -58,7 +58,7 @@ | |||||
</dependency> | ||||||
<dependency> | ||||||
<groupId>org.jenkins-ci.plugins</groupId> | ||||||
<artifactId>ssh-slaves</artifactId> | ||||||
<artifactId>ssh-agents</artifactId> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's an identifier, needs to remain the same
Suggested change
|
||||||
<scope>test</scope> | ||||||
</dependency> | ||||||
</dependencies> | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -268,7 +268,7 @@ private List<String> scriptLauncherCmd(ShellController c, FilePath ws, @CheckFor | |||||
|
||||||
/*package*/ static final class ShellController extends FileMonitoringController { | ||||||
|
||||||
/** Last time we checked the timestamp, in nanoseconds on the master. */ | ||||||
/** Last time we checked the timestamp, in nanoseconds on the Controller. */ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lower case
Suggested change
|
||||||
private transient long lastCheck; | ||||||
/** Last-observed modification time of {@link FileMonitoringTask.FileMonitoringController#getLogFile(FilePath)} on remote computer, in milliseconds. */ | ||||||
private transient long checkedTimestamp; | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -640,7 +640,7 @@ private static class Watcher implements Runnable { | |||||
Timer.get().schedule(this, 100, TimeUnit.MILLISECONDS); | ||||||
} | ||||||
} catch (Exception x) { | ||||||
// note that LOGGER here is going to the agent log, not master log | ||||||
// note that LOGGER here is going to the agent log, not the Controller log | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lower case
Suggested change
|
||||||
LOGGER.log(Level.WARNING, "giving up on watching " + controller.controlDir, x); | ||||||
// Typically this will have been inside Handler.output, e.g.: | ||||||
// hudson.remoting.ChannelClosedException: channel is already closed | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -34,7 +34,7 @@ | |||||
|
||||||
/** | ||||||
* A remote handler which may be sent to an agent and handle process output and results. | ||||||
* If it needs to communicate with the master, you may use {@link VirtualChannel#export}. | ||||||
* If it needs to communicate with the Controller, you may use {@link VirtualChannel#export}. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I assume the same here |
||||||
* @see Controller#watch | ||||||
*/ | ||||||
public abstract class Handler implements Serializable { // TODO 2.107+ SerializableOnlyOverRemoting | ||||||
|
@@ -57,7 +57,7 @@ public abstract class Handler implements Serializable { // TODO 2.107+ Serializa | |||||
* <p>Any metadata associated with the process may be deleted after this call completes, rendering subsequent {@link Controller} calls unsatisfiable. | ||||||
* <p>Note that unlike {@link Controller#exitStatus(FilePath, Launcher)}, no specialized {@link Launcher} is available on the agent, | ||||||
* so if there are specialized techniques for determining process liveness they will not be considered here; | ||||||
* you still need to occasionally poll for an exit status from the master. | ||||||
* you still need to occasionally poll for an exit status from the controller. | ||||||
* @param code the exit code, if known (0 conventionally represents success); may be negative for anomalous conditions such as a missing process | ||||||
* @param output standard output captured, if {@link DurableTask#captureOutput} was called; else null | ||||||
* @throws Exception if anything goes wrong, this watch is deactivated | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly different for linguistic reasons. The previous entry used the "plugin ID" which is not well known to users and is unchanging even for inclusive naming. Let's use the plugin name rather than the identifier