Migrate tests to JUnit5 #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
jtnord
requested changes
Mar 21, 2025
Member
jtnord
left a comment
jtnord
left a comment
There was a problem hiding this comment.
Thanks for this, however the majority of the code here is a fork and we do not rally wish to maintain it or deviate it from the upstream over the security fix that was done (the reason it is here).
Additionally we may be likely to pull this code out of the plugin to a separate library in the near future.
The eddsa library is crypto sensitive and as such I would not want to risk the possibility of introducing any regressions.
this plugin is also only here until plugins have migrated away to a modern maintained alternative (either bouncycastle or JDK15+)
Contributor
Author
|
Noting https://github.com/testcontainers/testcontainers-java/releases/tag/2.0.0 dropping JUnit 4 support blocking #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
There are 3 exceptions where a migration was not possible as the tests rely on
Ruleimplementations that have not (yet) been migrated to JUnit5:EddsaTestusingRealJenkinsRuleEddsaTestWithFreestyleProjectusingRealJenkinsRuleFIPSComplianceCheckTestusingRealJenkinsRuleI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.