-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for RunBadgeAction #249
Add a test for RunBadgeAction #249
Conversation
Thanks @Subhojit-Dey1234 . You'll need to run |
@MarkEWaite thanks for mentioning. I have updated. |
tagging #114 for getting it added in the list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally prefer to avoid mock objects when I can test the object with a JenkinsRule
based test. The JenkinsRule
based test is closer to the way the object is used in a real Jenkins controller.
The mock tests that remain are tests that I could not see how to easily duplicate with a JenkinsRule
test. The getUrl
test should be feasible by using a JenkinsRule that invokes a WebClient. However, I ran out of time to do that additional effort.
Very nice pull request. Ready to merge once the CI job passes.
[JENKINS-70464] Added test case for
RunBadgeAction
Added Test cases
Jira issue - JENKINS-70464
Testing done