Skip to content

[JENKINS-70464] Test EmbeddableBadgeConfigsAction - #250

Merged
MarkEWaite merged 6 commits into
jenkinsci:masterfrom
abhishekmaity:test-coverage-2
Oct 9, 2023
Merged

[JENKINS-70464] Test EmbeddableBadgeConfigsAction#250
MarkEWaite merged 6 commits into
jenkinsci:masterfrom
abhishekmaity:test-coverage-2

Conversation

@abhishekmaity

@abhishekmaity abhishekmaity commented Oct 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

In response to #114,

Testing done

  • added EmbeddableBadgeConfigsActionTest.java
  • Test coverage shown below

Screenshot 2023-10-09 012452

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@abhishekmaity
abhishekmaity requested a review from a team as a code owner October 8, 2023 19:59
@abhishekmaity abhishekmaity changed the title [JENKINS-70464] Test 'EmbeddableBadgeConfigsActionTest' [JENKINS-70464] Test EmbeddableBadgeConfigsAction Oct 8, 2023
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Oct 8, 2023
MarkEWaite
MarkEWaite requested changes Oct 8, 2023
View reviewed changes

@MarkEWaite MarkEWaite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused mock objects and the two tests that are not testing anything in the target class.

Comment thread src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated
Comment thread src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated
Comment thread src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated
Comment thread src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated
abhishekmaity and others added 4 commits October 9, 2023 21:04
@abhishekmaity @MarkEWaite
Update src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBa…
6619af1 
…dgeConfigsActionTest.java

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@abhishekmaity @MarkEWaite
Update src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBa…
b657d70 
…dgeConfigsActionTest.java

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@abhishekmaity @MarkEWaite
Update src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBa…
23d1a41 
…dgeConfigsActionTest.java

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@abhishekmaity @MarkEWaite
Update src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBa…
852cf4e 
…dgeConfigsActionTest.java

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@abhishekmaity

abhishekmaity commented Oct 9, 2023

Copy link
Copy Markdown
Contributor Author

@MarkEWaite changes applied as per suggestion

MarkEWaite
MarkEWaite approved these changes Oct 9, 2023
View reviewed changes

@MarkEWaite MarkEWaite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
MarkEWaite merged commit 01b7dfc into jenkinsci:master Oct 9, 2023
@abhishekmaity
abhishekmaity deleted the test-coverage-2 branch October 9, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees

No one assigned

Labels

tests Automated test addition or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhishekmaity @MarkEWaite