Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to publish not-ready addresses #1272

Conversation

maxnitze
Copy link
Contributor

@maxnitze maxnitze commented Jan 2, 2025

What does this PR do?

Adds the option to set the publishNotReadyAddresses flag on the controller service. This allows traffic to get to the controller before its pod reports itself ready.

The Jenkins controller has its own way of dealing with requests while it is still starting. It shows a startup page until the service is ready. This also allows the "auto-refresh when done" feature when doing a restart from the UI to work (again).

Submitter checklist

Preview Give feedback

Special notes for your reviewer

This flag was broken in very early Kubernetes releases (see kubernetes/kubernetes#58662 for example). So this feature is not working on Jenkns instances running in Kubernetes <=1.11. Which should be okay, I think 😄

@maxnitze maxnitze requested a review from a team as a code owner January 2, 2025 22:38
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey LGTM. if you can rebase to fix the conflicts.

I do wonder whether this should be the default, but this is fine for now.

@maxnitze maxnitze force-pushed the feat/add-option-to-publish-not-ready-addresses branch from 9eb9d79 to 5a9857e Compare January 3, 2025 09:12
@maxnitze
Copy link
Contributor Author

maxnitze commented Jan 3, 2025

I do wonder whether this should be the default, but this is fine for now.

Yeah, thought so too. But I did not want to make this "breaking".

I rebased the branch onto main and solved the conflicts.

@timja timja merged commit 5b97b17 into jenkinsci:main Jan 3, 2025
6 checks passed
@maxnitze maxnitze deleted the feat/add-option-to-publish-not-ready-addresses branch January 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants