Add option to publish not-ready addresses #1272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the option to set the
publishNotReadyAddresses
flag on the controller service. This allows traffic to get to the controller before its pod reports itself ready.The Jenkins controller has its own way of dealing with requests while it is still starting. It shows a startup page until the service is ready. This also allows the "auto-refresh when done" feature when doing a restart from the UI to work (again).
Submitter checklist
Special notes for your reviewer
This flag was broken in very early Kubernetes releases (see kubernetes/kubernetes#58662 for example). So this feature is not working on Jenkns instances running in Kubernetes <=1.11. Which should be okay, I think 😄