Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 20, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.guava:guava 33.4.0-jre -> 33.4.5-jre age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file skip-changelog Should not be shown in the changelog labels Mar 20, 2025
@gbhat618
Copy link
Contributor

The DisconnectNodeCommandTest failures are getting fixed in #10425

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The issue with flakey tests was fixed in separate PR #10425.

@renovate renovate bot force-pushed the renovate/guava-monorepo branch from e1082c0 to 2e9fde7 Compare March 20, 2025 20:48
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Guava 33.4.5 release notes recommend a review of the release notes for Guava 33.4.1. Those release notes explain that Guava is improving its nullness annotations with 33.4.1 - 33.4.5 and that most users can upgrade directly to 33.4.5.

I didn't see any issues when I ran a Jenkins controller with this build. Some of the things that I checked included:

  • Use the default set of plugins from the setup wizard
  • Add a static Windows agent, a static Linux agent, and a Docker cloud that can run Alpine agents
  • Run declarative Pipeline examples that use each of those agents
  • Install and remove plugins
  • Run a Pipeline on Alpine (container) that sleeps, restart Jenkins, confirm that the Pipeline completes as expected

No reports related to runtime issues for nullness in any of that interactive testing.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 20, 2025
@krisstern krisstern merged commit 5c85d8f into master Mar 21, 2025
19 checks passed
@krisstern krisstern deleted the renovate/guava-monorepo branch March 21, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants