[JENKINS-57456] User language prefer setting support #8
Conversation
There was a problem hiding this comment.
Looks alright to me :)
@oleg-nenashev any chance for a review on this?
|
Sorry, I missed it. Added to my review queue |
There was a problem hiding this comment.
requesting changes due to some bits in exception handling. Bt thanks a lot @LinuxSuRen , I am looking forward to add this feature!
|
@LinuxSuRen if you are still interested in it, could you please also reference this feature in README.md? It will become the main documentation source after #9 |
Co-Authored-By: Oleg Nenashev <[email protected]>
Co-Authored-By: Oleg Nenashev <[email protected]>
|
Looks like some tests legitimately fail |
|
I finally realized that I was not watching this repo... Sorry |
Co-Authored-By: Oleg Nenashev <[email protected]>
Co-Authored-By: Oleg Nenashev <[email protected]>
|
Hmm... tests fail |
| @@ -30,6 +31,9 @@ you're using have been translated into the specified language). | |||
| To additionally force this language on all users, overriding their browser language, | |||
| you can check the "Ignore browser preference and force this language to all users" option. | |||
|
|
|||
| If you want to have a different language setting for your user, please configure a custom locale in your profile settings page. | |||
| This feature needs to be firstly enabled by the Jenkins instance admins in global settings. | |||
There was a problem hiding this comment.
Admins may want to enforce the locale on the instance. E.g. it would be my approach
|
Any updates? |
|
@LinuxSuRen sorry. Tests were failing, and I did not watch it closely |
|
@LinuxSuRen Hi, is this PR still relevant ? Would be nice to rebase and ensure test are passing (Also is missing a JCasC test since 144.v1a_998824ddb_3) Regards, |
No description provided.