-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73879] Remove inline JavaScript for rootPOM
validation
#345
Open
yaroslavafenkin
wants to merge
1
commit into
jenkinsci:master
Choose a base branch
from
yaroslavafenkin:JENKINS-73879
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavafenkin
added a commit
to yaroslavafenkin/acceptance-test-harness
that referenced
this pull request
Oct 9, 2024
yaroslavafenkin
added a commit
to yaroslavafenkin/bom
that referenced
this pull request
Oct 9, 2024
basil
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Oct 9, 2024
jenkinsci/maven-plugin#345 with CSP improvements
basil
changed the title
[JENKINS-73879] Remove inline JS for
[JENKINS-73879] Remove inline JavaScript for Oct 9, 2024
rootPOM
validationrootPOM
validation
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 10, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 10, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 11, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 11, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 14, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 14, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 15, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 15, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 16, 2024
basil
added a commit
to basil/acceptance-test-harness
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73879
Testing done
I thought recording a video for such change would be an overkill, so I'll provide some screenshots. Let me know if it's enough.
Before the change
Each time I trigger a validation on the
rootPOM
field on the configuration page of a Maven Project an error in the console appears:Checking the Content Security Policy report (provided by Content Security Policy) we can see there's a violation:
Parameter received on the server side:
After the change
Triggering validation multiple times on the project configuration page yields no errors in the console:
Content Security Policy report remains clear:
Value of the parameter is still received correctly by the server:
Submitter checklist
Link to relevant pull requests, esp. upstream and downstream changes