Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73879] Remove inline JavaScript for rootPOM validation #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaroslavafenkin
Copy link

@yaroslavafenkin yaroslavafenkin commented Oct 8, 2024

JENKINS-73879

Testing done

I thought recording a video for such change would be an overkill, so I'll provide some screenshots. Let me know if it's enough.

Before the change

Each time I trigger a validation on the rootPOM field on the configuration page of a Maven Project an error in the console appears:
image

Checking the Content Security Policy report (provided by Content Security Policy) we can see there's a violation:
image

Parameter received on the server side:
image

After the change

Triggering validation multiple times on the project configuration page yields no errors in the console:
image

Content Security Policy report remains clear:
image

Value of the parameter is still received correctly by the server:
image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner October 8, 2024 16:13
yaroslavafenkin added a commit to yaroslavafenkin/acceptance-test-harness that referenced this pull request Oct 9, 2024
yaroslavafenkin added a commit to yaroslavafenkin/bom that referenced this pull request Oct 9, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil requested a review from olamy October 9, 2024 16:31
MarkEWaite added a commit to MarkEWaite/docker-lfs that referenced this pull request Oct 9, 2024
@basil basil changed the title [JENKINS-73879] Remove inline JS for rootPOM validation [JENKINS-73879] Remove inline JavaScript for rootPOM validation Oct 9, 2024
@basil basil added the internal label Oct 9, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 10, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 10, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 11, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 11, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 14, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 14, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 15, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 15, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 16, 2024
basil added a commit to basil/acceptance-test-harness that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants