JENKINS-62437: Remove table tags to avoid UI breakage #86
+74
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Apr 27, 2021
timja
reviewed
Apr 27, 2021
Hickstone
force-pushed
the
bugfix/table_to_div_migration
branch
from
8986b25 to
849f05f
Compare
oleg-nenashev
requested changes
Apr 28, 2021
|
This may fix JENKINS-66034. |
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
@Dohbedoh to move it forward, the documentation needs to be fixed, and you need to test the layouts on the screens that have and have not been migrated to divs yet
Add cell and row wrapper tags to support the new div layout. This avoids other items (from other plugins) being cut of on the build overview.
Hickstone
force-pushed
the
bugfix/table_to_div_migration
branch
from
085b648 to
6ada634
Compare
Author
|
The documentation is fixed. I would appreciate a test of an independend reviewer to make sure everything works (not just on my machine). |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cell and row wrapper tags to support the new div layout.
This avoids other items (from other plugins) being cut of on the build overview.
Like #83, but with the fixed floatingBoxTemplate
@oleg-nenashev
@timja