Skip to content

Conversation

@slide
Copy link
Member

@slide slide commented Dec 23, 2024

Upgrade VS tool version and build native components using Maven. A clean is also supported and called during the maven clean operation.

Testing done

Ran build with mvn clean package

See #119

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I do not recall why it was still required to keep binaries in the repository but, if there is no longer need, that's perfect too.

My recommendation would be to set up a Dev Container for native compilation so that there is no dependency on the local environment - https://learn.microsoft.com/en-us/visualstudio/install/build-tools-container . Windows containers are still not very fun though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants