Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-55341] Loading library only once and storing it in common place from where all pipeline builds which use that version can access it #58

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pragnesh-is
Copy link

@pragnesh-is pragnesh-is commented Dec 27, 2018

This is PR to solve issue: https://issues.jenkins-ci.org/browse/JENKINS-55341

If new checkbox usingTagsOnly is checked, we will store global libraries under jenkins_home in separate folder for each version and if that folder is available it wouldn't checked for update in remote git repo. For folder specific libraries, it will be stored inside workspace of folder job where it is configured. Dynamic library loading will not support this feature, if retriever is configured.

@pragnesh-is pragnesh-is changed the title [https://issues.jenkins-ci.org/browse/JENKINS-55341] Loading library only once and storing it in common place from where all pipeline builds which use that version can access it from same location [JENKINS-55341] Loading library only once and storing it in common place from where all pipeline builds which use that version can access it from same location Dec 27, 2018
@pragnesh-is pragnesh-is changed the title [JENKINS-55341] Loading library only once and storing it in common place from where all pipeline builds which use that version can access it from same location [JENKINS-55341] Loading library only once and storing it in common place from where all pipeline builds which use that version can access it Dec 27, 2018
@jglick
Copy link
Member

jglick commented Jan 8, 2019

#50 is further along and might subsume the benefits of this, TBD.

@pragnesh-is
Copy link
Author

pragnesh-is commented Jan 9, 2019

#50 solves only one problem of network processing but this PR #58 solves both problems of optimizing network processing and disk usage. Also, in PR #50 they did not find that as best implementation, So Please can you review this approach which solves both problems ?

@atmcarmo
Copy link

atmcarmo commented Feb 22, 2021

Hi @pragnesh-is could you share again your source branch? One of the issues I have is while loading/compiling the shared library (mainly disk issues), and not necessarily network problems. Thank you very much!

@jglick
Copy link
Member

jglick commented May 23, 2022

As of #172 most of the code in this plugin has been moved to another plugin repository so this PR must be closed. If this change is still needed, please

git clone https://github.com/jenkinsci/pipeline-groovy-lib-plugin
cd pipeline-groovy-lib-plugin
git checkout -b PLEASE-SELECT-BRANCH-NAME
git pull https://github.com/pragnesh-is/workflow-cps-global-lib-plugin master

resolve any merge conflicts, and file a fresh PR on the new repository. Be sure to paste a link to this old PR to enable bidirectional navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants