Merge pull request opendatahub-io#3007 from jeff-phillips-18/edit-mod…

…el-button [RHOAIENG-6851] Fix for Edit and Delete actions in Model tab
jenny-s51 · Jul 17, 2024 · be47fe4 · be47fe4
2 parents 7f56055 + af61562
commit be47fe4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 20 deletions.
diff --git a/...end/src/pages/modelServing/screens/projects/KServeSection/KServeInferenceServiceTable.tsx b/...end/src/pages/modelServing/screens/projects/KServeSection/KServeInferenceServiceTable.tsx
@@ -11,14 +11,14 @@ const KServeInferenceServiceTable: React.FC = () => {
   const [editKserveResources, setEditKServeResources] = React.useState<
     | {
         inferenceService: InferenceServiceKind;
-        servingRuntime: ServingRuntimeKind;
+        servingRuntime?: ServingRuntimeKind;
       }
     | undefined
   >(undefined);
   const [deleteKserveResources, setDeleteKServeResources] = React.useState<
     | {
         inferenceService: InferenceServiceKind;
-        servingRuntime: ServingRuntimeKind;
+        servingRuntime?: ServingRuntimeKind;
       }
     | undefined
   >(undefined);

diff --git a/.../src/pages/modelServing/screens/projects/KServeSection/KServeInferenceServiceTableRow.tsx b/.../src/pages/modelServing/screens/projects/KServeSection/KServeInferenceServiceTableRow.tsx
@@ -21,11 +21,11 @@ type KServeInferenceServiceTableRowProps = {
   obj: InferenceServiceKind;
   onEditKServe: (obj: {
     inferenceService: InferenceServiceKind;
-    servingRuntime: ServingRuntimeKind;
+    servingRuntime?: ServingRuntimeKind;
   }) => void;
   onDeleteKServe: (obj: {
     inferenceService: InferenceServiceKind;
-    servingRuntime: ServingRuntimeKind;
+    servingRuntime?: ServingRuntimeKind;
   }) => void;
   rowIndex: number;
 };
@@ -67,22 +67,8 @@ const KServeInferenceServiceTableRow: React.FC<KServeInferenceServiceTableRowPro
           isGlobal={false}
           showServingRuntime
           servingRuntime={servingRuntime}
-          onDeleteInferenceService={() => {
-            if (servingRuntime) {
-              onDeleteKServe({
-                inferenceService: obj,
-                servingRuntime,
-              });
-            }
-          }}
-          onEditInferenceService={() => {
-            if (servingRuntime) {
-              onEditKServe({
-                inferenceService: obj,
-                servingRuntime,
-              });
-            }
-          }}
+          onDeleteInferenceService={() => onDeleteKServe({ inferenceService: obj, servingRuntime })}
+          onEditInferenceService={() => onEditKServe({ inferenceService: obj, servingRuntime })}
         />
       </ResourceTr>
       <ResourceTr isExpanded={isExpanded} resource={obj}>