[WIP] Rename Gi/Mi size names to GiB/MiB #20
Closed
+21
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-291
WIP - needs clarity on whether or not to use concatenation for all instances in the UI where the units aren't explicitly declared as strings and come from the back end.
Description
Use
GiB
andMiB
as the visual representation in the UI while keeping the current usage ofGi
andMi
under the hood.How Has This Been Tested?
Tested on Model Serving cluster.
Test Impact
Tests already exist, units have been updated.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main