Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rename Gi/Mi size names to GiB/MiB #20

Closed
wants to merge 6 commits into from
Closed

Conversation

jenny-s51
Copy link
Owner

@jenny-s51 jenny-s51 commented Oct 11, 2024

https://issues.redhat.com/browse/RHOAIENG-291

WIP - needs clarity on whether or not to use concatenation for all instances in the UI where the units aren't explicitly declared as strings and come from the back end.

Description

Use GiB and MiB as the visual representation in the UI while keeping the current usage of Gi and Mi under the hood.

How Has This Been Tested?

Tested on Model Serving cluster.

  1. Create a DS project.
  2. Add a workbench.
  3. Go to the "Cluster Storage" tab in the selected DS project.
  4. Click "Add storage".
  5. Go to kebab menu on

Test Impact

Tests already exist, units have been updated.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Owner Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied feedback from @jeff-phillips-18 and @christianvogt. Closing in favor of opendatahub-io#3338.

@jenny-s51 jenny-s51 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant