Skip to content

start improving dbreaders - #346

Merged
jepegit merged 2 commits into
masterfrom
339-batch-plotting-with-multiple-subfigures
Nov 12, 2025
Merged

start improving dbreaders#346
jepegit merged 2 commits into
masterfrom
339-batch-plotting-with-multiple-subfigures

Conversation

@jepegit

@jepegit jepegit commented Nov 12, 2025

Copy link
Copy Markdown
Owner

Note

Introduce BaseSimpleDbReader and switch Excel/SQL readers to it; add JSON DB reader scaffold; update batch engine to accept reader type strings and streamline field retrieval.

  • DB Reader Abstractions:
    • Add BaseSimpleDbReader with concrete per-cell accessors and from_batch contract.
    • Extend BaseDbReader with from_batch(...) signature.
    • Switch dbreader.Reader and sql_dbreader.SQLReader to inherit from BaseSimpleDbReader.
  • New JSON Reader:
    • Add readers/json_dbreader.py with BaseJSONReader and BattBaseJSONReader (stub from_batch).
  • Batch Engine (utils/batch_tools/engines.py):
    • Allow simple_db_engine to accept reader by string (e.g., "simple_excel_reader", "batbase_json_reader").
    • Refactor journal field population using a loop; add fallback for missing file_name_indicator.
  • Misc:
    • Minor docstrings/type hints and interface cleanups in readers/core.py.

Written by Cursor Bugbot for commit 2a46e16. This will update automatically on new commits. Configure here.

@jepegit
jepegit merged commit 4f41c15 into master Nov 12, 2025
19 of 25 checks passed
@jepegit
jepegit deleted the 339-batch-plotting-with-multiple-subfigures branch February 28, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant