Decommission in-repo legacy summary engine (#385)#503
Merged
Conversation
Remove the duplicate compute path kept behind make_summary(old=True): _make_summar_legacy, _generate_absolute_summary_columns, _ir_to_summary, _end_voltage_to_summary (all legacy-exclusive), and the old kwarg + branch in make_summary. The cellpy-core engine is now the only summary path. The blocker noted on the issue is resolved: with cellpycore 0.2.1 the core summary on the arbin_sql_h5 file is value-identical to the legacy engine on every common column (1 summary row from 47 raw rows). The remaining difference is that the core path prunes 13 duplicate raw rows (47 -> 34) as a side effect; the test now records that as an explicit contract. Breaking (v2 line): the old kwarg is gone. 1.x users keep it on the v1.x branch. Closes #385. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #385 — the last open item of the v2 Phase 0 gate (epic #402).
What
Removes the in-repo legacy summary engine, leaving cellpy-core as the only
compute path:
_make_summar_legacy,_generate_absolute_summary_columns,_ir_to_summary,_end_voltage_to_summary(all verified legacy-exclusive — no live callers)make_summary(old=True)branch and theoldkwarg itselfNet: −547 lines. Breaking on the v2 line only:
old=Trueis gone; 1.x userskeep it on the
v1.xbranch.The blocker is resolved
tests/test_arbin_sql_h5.pywas the soleold=Trueconsumer, kept because thecore summary "pruned duplicates differently" (TODO from the
cellpycore==0.1.5era). Re-tested on
cellpycore==0.2.1:The summary is value-identical on every common column. The raw-row pruning is a
side effect of the core path; the test now asserts it explicitly (47 → 34) so it
is a recorded contract rather than a surprise.
Verification
tests/test_arbin_sql_h5.py: 1 passed (core path)uv run pytest -m essential: 93 passeduv run pytest: 592 passed, 62 skipped, 14 xfailed, 0 failures🤖 Generated with Claude Code