Drop redundant module-level header constants (#505)#512
Merged
Conversation
Remove the HEADERS_NORMAL / HEADERS_SUMMARY / HEADERS_STEP_TABLE module constants (marked "TODO refactor this (not needed)") from cellreader.py and data_structures.py. CellpyCell methods use the existing self.headers_* instance attributes; module-level functions call the get_headers_*() accessors from internal_settings. Drop the now-unused imports. No third copy of header definitions remains; the header-parity contract tests (#378) guard the single source. Part of the v2 Phase 0 gate (epic #402). Closes #505. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved. Cursor Bugbot was not configured for this repository, so that signal was skipped; the change is a straightforward header-constant cleanup with no applicable approval policies requiring human review. No reviewers were assigned.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505 — final item of the v2 Phase 0 gate (epic #402).
What
Removes the redundant module-level
HEADERS_NORMAL/HEADERS_SUMMARY/HEADERS_STEP_TABLEconstants (all carrying# TODO refactor this (not needed))from
cellreader.pyanddata_structures.py:CellpyCell.split_many/with_cyclesuse the existingself.headers_*instance attributes.
data_structures.pycall theget_headers_*()accessors from
internal_settingsdirectly.No third copy of header definitions remains;
internal_settings(backed by thecore parity contract, #378) is the single source. No external code imported these
constants (verified by grep).
Verification
uv run pytest -m essential: 93 passeduv run pytest: 592 passed, 62 skipped, 14 xfailed, 0 failuresWith #385 (merged today) and #504 (closed — already done by #451), this
completes Phase 0; v2 feature work (#506) is unblocked.
🤖 Generated with Claude Code