Port summary prepare path and flip summary_plot to prepare→spec→render (#638)#644
Merged
Merged
Conversation
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Draft approach for extracting prepare/summary.py, completing PlotlyBackend.render, and switching public summary_plot onto the prepare→spec→render path while keeping SeabornPlotBuilder until #639. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Extract SummaryPlotDataPreparer into cellpy.plotting.prepare.summary, emit a real FigureSpec, and draw interactive figures through PlotlyBackend.render. Delete PlotlyPlotBuilder and the provisional CELLPY_SUMMARY_PLOTLY_SPEC dual path; keep SeabornPlotBuilder on the same prepared frame until #639. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Record the Unreleased HISTORY bullet and move issue638 tracking files to 03-solved-issues with Done checked after green closeout tests. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
jepegit
marked this pull request as ready for review
July 23, 2026 05:41
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
jepegit
enabled auto-merge (squash)
July 23, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #638 (epic #567 Stage 1): port summary prepare into
cellpy.plotting.prepare, emit a realFigureSpec, and flip publicsummary_plotonto prepare → spec →PlotlyBackend.render.Changes
cellpy/plotting/context.py— minimalCellContext/from_sourcecellpy/plotting/prepare/summary.py— preparer +(frame, FigureSpec)PlotlyBackend.renderabsorbs formerPlotlyPlotBuilder(incl. no-formation); provisionalCELLPY_SUMMARY_PLOTLY_SPECremovedsummary_plotorchestrates context → registry → prepare → render;SeabornPlotBuilderkept until Matplotlib backend; retire SeabornPlotBuilder; unify backend= #639 on the same frameSummaryPlotDataPreparer/PlotlyPlotBuilderfromplotutilstests/test_summary_prepare.py.issueflows/03-solved-issues/Test plan
Closeout verified: figure-spec/prepare suites + essential gate green.