Port cycles_plot to prepare→spec→render (#646)#649
Merged
Conversation
Capture the confirmed approach for Stage 2: prepare/curves, registry family, backend cycles branch, and range/backend deprecations. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Add prepare/curves.py and a cycles PlotFamily, route public cycles_plot through get_backend().render with kind=cycles branches in plotly/mpl, and deprecate interactive=/xlim/ylim in favor of backend=/x_range/y_range. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Record the cycles_plot prepare→spec→render port under Unreleased and move the issue group to 03-solved-issues with Done checked. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
jepegit
marked this pull request as ready for review
July 23, 2026 10:18
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #646 (epic #567 Stage 2): port
cycles_plotonto prepare → spec → render.Changes
cellpy/plotting/prepare/curves.py— curve frame +FigureSpec(kind="cycles")"cycles"family withentry_point="cycles_plot"(summary oracle stays filtered)PlotlyBackend/MatplotlibBackendcycles render branch (ported private plotters)cycles_plot:backend=; deprecateinteractive=/xlim/ylim→x_range/y_rangetests/test_cycles_prepare.py; oracle cases onbackend=HISTORY.mdUnreleased bullet; issue docs archived under.issueflows/03-solved-issues/Test plan
MPLBACKEND=Agg uv run pytest tests/test_cycles_prepare.py tests/test_figure_specs.py tests/test_plotting_registry.py -qMPLBACKEND=Agg uv run pytest -m essential --ignore=tests/test_arbin_variants_two_stage.py(562 passed)Depends on
#639 (merged)