build(deps): bump plexus-utils from 3.5.1 to 4.0.0

[dependabot]

Bumps plexus-utils from 3.5.1 to 4.0.0.

Release notes

Sourced from plexus-utils's releases.

4.0.0

• Fix SCM information (#254) @​gnodet
• Fix non contiguous imports (#255) @​gnodet
• Fix false difference detected with CachingOutputStream/CachingWriter when streams are flushed (#252) @​gnodet

📦 Dependency updates

• Switch to junit 5 (#245) @​gnodet

👻 Maintenance

• Switch to junit 5 (#245) @​gnodet
• Remove unused/unmaintained jira export (#247) @​gnodet
• Switch build ci workflow to master branch (#250) @​slachiewicz
• Bump maven-resources-plugin from 2.7 to 3.3.1 (#209) @​dependabot

Commits

• 0803079 [maven-release-plugin] prepare release plexus-utils-4.0.0
• b342c7c Switch to released version of plexus-xml 4.0.0
• 968a069 Reformat using spotless:apply
• 4315308 Update to parent 13
• 0a84396 Fix SCM information (#254)
• 14ac2e1 Fix non contiguous imports (#255)
• 3bd741d Fix false difference detected with CachingOutputStream/CachingWriter when str...
• b4ee91f Switch to junit 5 (#245)
• 60b1b79 Remove unused/unmaintained jira export (#247)
• cbca15a Switch build ci workflow to master branch (#250)
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[nhumblot]

Hi 👋

I fixed the pipeline by changing the dependency. The classes used by the maven plugin got moved to a new plexus-xml artifact. I am not approving this PR as I have committed on the branch but LGTM. 🙂

[aikebah]

@nhumblot The plexus-utils dependency was not only there to satisfy implementation needs, but also as an override to override the vulnerable transitive dependency versions of it

plexus-utils-3.0.10.jar (pkg:maven/org.codehaus.plexus/[email protected], cpe:2.3:a:plexus-utils_project:plexus-utils:3.0.10:*:*:*:*:*:*:*, cpe:2.3:a:utils_project:utils:3.0.10:*:*:*:*:*:*:*) : CVE-2017-1000487

So plexus-utils at 4.0.1 should remain included with the 'override vulnerable transitive dependency' comment

The transitive dependencies can be found using mvn dependency:tree -Dincludes=org.codehaus.plexus:plexus-utils

[INFO] --- dependency:3.5.0:tree (default-cli) @ dependency-check-core ---
[INFO] org.owasp:dependency-check-core:jar:8.2.2-SNAPSHOT
[INFO] \- org.apache.maven.scm:maven-scm-provider-cvsexe:jar:1.8.1:test
[INFO]    \- org.codehaus.plexus:plexus-utils:jar:3.0.7:test
...
[INFO] --- dependency:3.5.0:tree (default-cli) @ dependency-check-maven ---
[INFO] org.owasp:dependency-check-maven:maven-plugin:8.2.2-SNAPSHOT
[INFO] \- org.apache.maven:maven-settings:jar:3.1.0:provided
[INFO]    \- org.codehaus.plexus:plexus-utils:jar:3.0.10:compile

Besides those I'm not so sure whether it would be a good idea to onboard on this major now, as it depends on alpha versions of Maven 4 libraries.

[INFO] +- org.codehaus.plexus:plexus-xml:jar:4.0.1:compile
[INFO] |  \- org.apache.maven:maven-xml-impl:jar:4.0.0-alpha-5:compile
[INFO] |     \- org.apache.maven:maven-api-xml:jar:4.0.0-alpha-5:compile
[INFO] |        \- org.apache.maven:maven-api-meta:jar:4.0.0-alpha-5:compile

[aikebah]

LGTM

Going by maven's own plugins adopting plexus 4.x on plugins targeting Maven 3.x is fine, already done in e.g. https://github.com/apache/maven-plugin-tools/tree/maven-plugin-tools-3.9.0 and https://github.com/apache/maven-clean-plugin/releases/tag/maven-clean-plugin-3.3.1

[nhumblot]

@aikebah 👋

Thank you for the pointer. When looking at it, we may be able to upgrade the maven.api.version property to the latest stable version, which should make the transitive dependency override unnecessary. 🤔

Would you like me to track this in an issue and submit a PR for it?

[aikebah]

@nhumblot maven.api.version should be kept in-sync with the minimum maven version that we support in the plugin

DependencyCheck/maven/pom.xml

Lines 40 to 42 in a7004d6

	<prerequisites>
	<maven>3.1.0</maven>
	</prerequisites>

It would be good though to make this link explicit and use the property in that spot.

But I think we could go with the same policy as the maven community itself which is nowadays taken maven 3.2.5 API compatibility backward compatibility support for current plugins. (which would still require the dependencyManagement override for plexus-utils)