Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Gitlab report broken after NVD api changes #6166

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: Gitlab report broken after NVD api changes #6166

merged 2 commits into from
Nov 29, 2023

Conversation

weyhmueller
Copy link
Contributor

Fixes Issue #6165

Description of Change

This PR restores the functionality from PR #5920.

Have test cases been added to cover the new functionality?

no, this PR provides no new functionality

@boring-cyborg boring-cyborg bot added the core changes to core label Nov 28, 2023
@weyhmueller weyhmueller mentioned this pull request Nov 28, 2023
Closed
jeremylong
jeremylong approved these changes Nov 28, 2023
View reviewed changes
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong
Copy link
Owner

Sorry that I missed that instance - I tried to find all instances of $vulnerability.cvssV3.getBaseSeverity() to add the getData() and looks like I missed this one. This update will be in the next release.

@jeremylong jeremylong added this to the 9.0.2 milestone Nov 28, 2023
@jeremylong jeremylong merged commit 355736f into jeremylong:main Nov 29, 2023
6 checks passed
@weyhmueller weyhmueller mentioned this pull request Dec 1, 2023
Closed
@weyhmueller weyhmueller deleted the fix/gitlab-report-broken branch December 1, 2023 18:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylong jeremylong jeremylong approved these changes

Assignees
No one assigned
Labels
core changes to core
Projects
None yet
Milestone
9.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@weyhmueller @jeremylong