Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure valid JSON output for gitlab report #6630

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Apr 28, 2024

Fixes Issue #6593

Description of Change

Add a different guard for adding a comma, so that in case of nameless dependencies no trailing comma is added.

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added the core changes to core label Apr 28, 2024
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong added this to the 9.2.0 milestone Apr 29, 2024
@jeremylong jeremylong merged commit d464dee into main Apr 29, 2024
6 checks passed
@jeremylong jeremylong deleted the issue-6593 branch April 29, 2024 13:49
@jeremylong
Copy link
Owner

I will try and release 9.2 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants