Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable configuration of a lower resultsPerPage on NVD API #6843

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Jul 15, 2024

Fixes Issue #6841

Description of Change

Add configurability of resultsPerPage parameter towards the NVD API to values lower than the default of 2000 in response to indicators that some environments are restricted to lower limits.

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added ant changes to ant cli changes to the cli core changes to core documentation site documentation maven changes to the maven plugin utils changes to utils labels Jul 15, 2024
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong
Copy link
Owner

In addition to the configuration change, I made the OVC auto-adust if the NVD provides a response saying the resultsPerPAge is too high.

@jeremylong jeremylong merged commit ffbc6d8 into main Jul 16, 2024
6 checks passed
@jeremylong jeremylong deleted the issue-6841 branch July 16, 2024 10:19
@jeremylong jeremylong added this to the 11.0 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ant changes to ant cli changes to the cli core changes to core documentation site documentation maven changes to the maven plugin utils changes to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants