Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove the need to specify dbDriver for external databases using JDBCv4 ServiceLoader supporting JDBC drivers #6938

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Aug 31, 2024

Fixes Issue #6937

Description of Change

  • Remove the pre-configured dbDriver so that no dbDriver override is required
  • Update documentation to more clearly specify that dbDriver specification is only required in specific scenarios
  • Issue a warning message when detecting explicit dbDriver configuration for a JDBC driver that is on the classpath

Have test cases been added to cover the new functionality?

no, a sensible test would require an external database server. Used the local test-project that surfaced the issue for validating the solution working with an external database. Existing test-cases proof that the removal of the dbDriver configuration is not affecting the use of the embedded h2 database (as the H2 driver is also fully supporting the JDBCv4 ServiceLoader mechanism).

@boring-cyborg boring-cyborg bot added ant changes to ant cli changes to the cli core changes to core documentation site documentation maven changes to the maven plugin labels Aug 31, 2024
@aikebah aikebah added this to the 11.0.0 milestone Aug 31, 2024
@jeremylong
Copy link
Owner

ack - merge conflicts that will likely take using beyond compare to figure out ;)

@aikebah
Copy link
Collaborator Author

aikebah commented Sep 4, 2024

@jeremylong I'll work on rebasing it to get rid of them... most likely effect of my editor autoformatting the file on edit

@aikebah
Copy link
Collaborator Author

aikebah commented Sep 4, 2024

IntelliJ IDEA with ignoring whitespace made the merge-conflict resolution easily.... a typo fix and addition of a missing path were the conflicting changes

@jeremylong jeremylong merged commit 5c4fec6 into main Sep 5, 2024
6 checks passed
@jeremylong
Copy link
Owner

Beyond Compare's diff would have been similar - if you ever have to diff a lot of code I always prefer using BC4. It is hands down the best diff tool available.

@jeremylong jeremylong deleted the issue-6937 branch September 5, 2024 10:04
@aikebah
Copy link
Collaborator Author

aikebah commented Sep 5, 2024

Up to now I've been quite satisfied with the 3-way merge of IntelliJ IDEA for resolving merge conflicts, but I do know that BeyondCompare is also a strong tool though I've never used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ant changes to ant cli changes to the cli core changes to core documentation site documentation maven changes to the maven plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External database configuration should not require specification of a Database Driver class
2 participants