Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve preloader animation #1255

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

dfsmania
Copy link
Collaborator

@dfsmania dfsmania commented Mar 5, 2024

Question Answer
Issue or Enhancement Enhancement
License MIT

What's in this PR?

Add some improvements to the preloader animation:

  • Add style="animation-iteration-count:infinite;" so the animation on the default content logo now plays indefinitely.

  • Use the img-circle class on the default logo content to get a circled styled logo.

  • A new configuration option (mode) is now available so the preloader may be attached into to the content-wrapper element instead of being fullscreen.

  • The default preloader content with a logo image may now be replaced completely using a new yielded section named preloader. At next, an example to replace the default preloader logo with a Font Awesome spinner icon:

    @extends('adminlte::page')
    
    ...
    
    {{-- Preloader replacement --}}
    
    @section('preloader')
        <i class="fas fa-4x fa-spin fa-spinner text-secondary"></i>
    @stop

Checklist

  • I tested these changes.
  • Create a PreloaderHelper class to split-out LayoutHelper.
  • Update related docs on Wiki.

@dfsmania dfsmania marked this pull request as draft March 5, 2024 20:31
@dfsmania dfsmania requested a review from resslinger March 5, 2024 20:59
@dfsmania dfsmania marked this pull request as ready for review March 6, 2024 15:38
@dfsmania dfsmania requested review from resslinger and removed request for resslinger March 8, 2024 13:38
@resslinger resslinger merged commit 21b94f6 into jeroennoten:master Mar 8, 2024
26 checks passed
@dfsmania dfsmania deleted the improve_preloader branch March 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants