Improve Gate Filter / Fix Issue #1111 #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gate filter now restrict submenu items with all restircted children
|
Caution Review this logic, will this also work for nested submenu items? |
|
Added test to check the logic on nested submenus. The logic actually work because deeper submenues are filtered/transformed first. |
|
@ruanpepe After inspecting the logic for menu creation, I decided to move the logic to filter an empty submenu to an upper level section, it's cleaner now and less tricky than adding it on the Gate Filter. I have created tests to cover the cases, but it would help more if you can test these changes in your environment too, it's just a minor change on the Regards! |
resslinger
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Improve the
Gatefilter to also restrict submenu items were all its children are also restricted.Fix #1111
Checklist