Kingman prototype#1
Conversation
There was a problem hiding this comment.
Minor style nit: there should be a space between the if and the bracket.
|
This is superb, thanks @JereKoskela! I think this is a great framework, and we'll be able to build the remaining functionality pretty easily on top of this. There are some minor changes I'd like to see:
|
|
I think I caught all the style discrepancies and removed the binary files. I also split up the z[] and r inits like we discussed. Self->num_parents still gets modified as before. Let me know if you spot anything else. |
There was a problem hiding this comment.
This file should be removed as well (KDE eh?).
There was a problem hiding this comment.
Also need to remove 'main' from the commit.
There was a problem hiding this comment.
space needed here - if (..)
Two new functions:
I've tried some trial simulations with small numbers of lineages and both few and many loci, and everything looks good. Valgrind also reports no memory leaks. But I haven't done extensive testing, which would probably be easier with a Python wrapper.