-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Likelihood Calculation Felsenstein #41
Merged
jeromekelleher
merged 3 commits into
jeromekelleher:main
from
Billyzhang1229:feature/maximum_likelihood
May 10, 2024
Merged
Likelihood Calculation Felsenstein #41
jeromekelleher
merged 3 commits into
jeromekelleher:main
from
Billyzhang1229:feature/maximum_likelihood
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9000585702Details
💛 - Coveralls |
63cad00
to
0638ffd
Compare
0638ffd
to
a019308
Compare
46e7756
to
99739dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor comments and good to merge.
e413ab6
to
df068d7
Compare
I'm adding one more test to cover all the cases |
OK, ping me when ready for final review |
df068d7
to
2021533
Compare
2021533
to
4896bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likelihood Calculation
This PR introduces a set of functions for computing the likelihood of phylogenetic trees.
Checklist
Felsenstein
's likelihood calculation._get_genotype_index
to find genotype indices in a mapping array._transition_probability
for calculating mutation transition probabilities._calculate_likelihood
to compute likelihoods using the transition probabilities.likelihood_felsenstein
as the high-level function orchestrating the likelihood computation.variant
vectorised version of likelihood calculation function.Notes
parallel=True
option in_likelihood_felsenstein
.