Remove deprecated enum conversions #5207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit enum conversion was deprecated in C++20 with the result that JerryScript doesn't compile in newer versions of Clang, in my case LLVM 20. This patch removes implicit enum conversions and instead performs explicit casts. JerryScript-DCO-1.0-Signed-off-by: Kasper Isager Dalsgarð <[email protected]>
|
Is there anything I can do to help land this? |
|
I'm hitting this on quite a few systems now, including macOS and Linux. A second review so this can land would be much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit enum conversion was deprecated in C++20 with the result that JerryScript doesn't compile in newer versions of Clang, in my case LLVM 20. This patch removes implicit enum conversions and instead performs explicit casts.