Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AES-CBC + HMAC-SHA256 #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

paragonie-scott
Copy link

Closes #1

@paragonie-scott
Copy link
Author

To be more precise: This closes one of the two issues mentioned in #1. However, the RNG bias was already reported in an HN comment and the author already said they were going to fix it, so I'm saving myself the trouble of needlessly duplicating effort.

@jes
Copy link
Owner

jes commented May 23, 2017

var mac = CryptoJS.HmacSHA256(data, key);

I think this should be computing a HMAC of unauthed, not data. But I tried changing it and that still didn't work, I've not investigated what was wrong.

@paragonie-scott
Copy link
Author

It looks like a cryptojs bug? I'm following their API as it's documented. Maybe I screwed something up though.

@jes jes mentioned this pull request May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants