Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to switch driving to correct side of road #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benknowles
Copy link

No description provided.

@lrvl
Copy link

lrvl commented Sep 23, 2022

Thanks!

@ppearson
Copy link

It was already "correct" for people in some countries, including the author by the looks of their domain name :)

@tteskac
Copy link

tteskac commented Sep 23, 2022

@benknowles few points:

  • I would suggest to adapt this PR so that your mirror CSS style is toggled with a button press, e.g. "S" (for "side") or whatever, because of what @ppearson said.
  • Just a kindly suggestion in general: use meaningful commit messages instead of "Updated index.html".

@jes
Copy link
Owner

jes commented Sep 23, 2022

I'm fine in principle with an option to swap the lane, but note:

  • the very subtle aeroplane effect will have the lights in the wrong colours if you do this (maybe you don't care)
  • I still want the default to be driving on the left

Possibly if we make the popup panel suggested in #1 (like in https://rezmason.github.io/drivey/ ) then that would be a good place to put the button to swap the lanes.

@jes jes changed the title fix: switch driving to correct side of road option to switch driving to correct side of road Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants